Skip to content

Conversation

@wanecek
Copy link
Contributor

@wanecek wanecek commented Mar 14, 2018

Summary

What

Add .prettierrc config file to allow editors to pick up the same settings as those defined in .eslintrc.js

Why

I managed to autoformat the files incorrectly a few times when working on #9. Was a bit annoying, maybe this can help someone in the future :)

Requirements (place an x in each [ ])

Not sure what tests to write to cover this. IMO it isn't necessary since we have eslint rules to enforce the rules :)
Couldn't access the CLA agreement found on cla-assistant.io :/

Avoid conflicts with editor- and user-configurations.
@codecov-io
Copy link

codecov-io commented Mar 14, 2018

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #10 +/- ## ===================================== Coverage 100% 100% ===================================== Files 2 2 Lines 117 117 Branches 5 5 ===================================== Hits 117 117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979deb8...ea75780. Read the comment docs.

Copy link
Contributor

@AnujRNair AnujRNair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2018

CLA assistant check
All committers have signed the CLA.

@AnujRNair AnujRNair merged commit 85a8543 into slackhq:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants