-   Notifications  You must be signed in to change notification settings 
- Fork 118
Added Button Component #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also added Buttons demo page
| Hi @jbennink, We are currently not convinced yet to componentize all the specific molecular elements by hand that are not specifcally styled by AdminLTE (other than bootstrap). If you look in te integration project, we adopt the Blazorised.Bootstrap as second dependency to adopt such elements (integration). What are your thoughts? See button page and namespacings in: | 
| I also wonder how far you should go. I did not know about Blazorise.Bootstrap. This package is not part of the Site or Site.Shared projects yet? Should I add it separate when I use the Blazor.AdminLte project? Extra: You currently have a Color enum, but Blazorise also has Color, should that merge or do they stay separate? | 
| The project https://github.com/sjefvanleeuwen/blazorized-adminlte-plugins show integration with Blazorise.Bootstrap buttons. That will stay a seperate project. If we make blazorise.bootstrap part of this main project, people will not have the opportunity to use another frameworks such as MatBlazor bootstrap. Hence we will keep the Color seperate. Intellisense will automatically choose the correct enumeration for the choosen framework. A down side is... that if you include Blazorize.Bootstrap you will have to make a distinction because there will be some ambiguity. For Example < Card > wil become something like <Blazor.AdminLte.Card>. Respectively for Blazorise.Bootstrap wil become something like <Blazorise.Card> Although that is the primary intention for namespaces. In otherwords different compontentization frameworks can be easily integrated through namespacing and work in unison. | 
| Isn't project Site (and Site.Shared) the Site that you, the user, makes so taking a dependency there would be fine.? Blazorise.AdminLte is de source for the nuget package? Correct? It's feels very cumbersome having duplicate components and types. The Buttons page used Card and Button. I removed my Button from UIElements but still prefixing Card, or button does not make switching compontentization frameworks very easy. And If you are going to need to change prefixes than you might be better of encapsulating components and hindg the compontentization framework dependancy there. But that feel like a lot of work. Isn't AdminLte based on Bootstrap so you really can't use Material, AntDesign, or MatBlazor together with AdminLte? | 
…he default bootstrap controls. This means we do not support XtraSmall, Flat and Gradient Buttons
| Are your intentions with Blazor.AdminLte to create only the controls not part of Blazorise? Then I wonder why Card and Carousel were started. Those are already in Blazorise. I think that is not a bad Idea, even though my changed Buttons page now looks less clean because of all the namespaces. I guess I could alias some to make them easier to read. | 
| To continue this discussion about project layout and how to separate things I have some more questions. Just curious and want to learn how other do things. Question: Was I correct in adding the Blazorise dependency to the Site.Shared project? Question: Is it correct to assume the Blazor.AdminLte.Site and Blazor.AdminLte.Site.Shared projects are "copied" and changed/used to create you "app" and the Blazor.AdminLte is taken as a nuget dependency? Question: What is the reason to have a Blazor.AdminLte.Content project that has copied versions of all javascript libraries instead of using LibMan? | 
| @jbennink do you want a microsoft teams session? So we can take you through the concepts. That might be easier to explain. | 
| 
 Yep on my work email (j.bennink@calway.nl), no problem that probably works faster. Not sure if you are still online, but we could schedule for tomorrow otherwise. I will be going home around 18:15 today | 
| I have reached the same conclusion, in regards to missing styles on the blazorise bootstrap components. Your initial proposal is preferred. I have commited the initial proposal under 573cdd5#diff-25d902c24283ab8cfbac54dfa101ad31 and reverted blazorise for record might we choose to use blazorise under a46465c#diff-25d902c24283ab8cfbac54dfa101ad31 | 
Added the Button component and the sample page ui/buttons.