Skip to content

Conversation

@jbennink
Copy link
Contributor

Added the Button component and the sample page ui/buttons.

@sjefvanleeuwen
Copy link
Owner

sjefvanleeuwen commented Aug 13, 2020

Hi @jbennink,

We are currently not convinced yet to componentize all the specific molecular elements by hand that are not specifcally styled by AdminLTE (other than bootstrap). If you look in te integration project, we adopt the Blazorised.Bootstrap as second dependency to adopt such elements (integration).

What are your thoughts?

See button page and namespacings in:
https://github.com/sjefvanleeuwen/blazorized-adminlte-plugins

@sjefvanleeuwen sjefvanleeuwen added question Further information is requested help wanted Extra attention is needed enhancement New feature or request labels Aug 13, 2020
@sjefvanleeuwen sjefvanleeuwen marked this pull request as draft August 13, 2020 11:13
@jbennink
Copy link
Contributor Author

I also wonder how far you should go. I did not know about Blazorise.Bootstrap. This package is not part of the Site or Site.Shared projects yet? Should I add it separate when I use the Blazor.AdminLte project?
I wanted to convert more pages from the AdminLte demo site, so that would mean Blazorise.Boorstrap should be added to Site.Shared?
If so I can amend this pull request to change it to use their Button.

Extra: You currently have a Color enum, but Blazorise also has Color, should that merge or do they stay separate?

@sjefvanleeuwen
Copy link
Owner

sjefvanleeuwen commented Aug 13, 2020

The project https://github.com/sjefvanleeuwen/blazorized-adminlte-plugins show integration with Blazorise.Bootstrap buttons. That will stay a seperate project.

If we make blazorise.bootstrap part of this main project, people will not have the opportunity to use another frameworks such as MatBlazor bootstrap. Hence we will keep the Color seperate. Intellisense will automatically choose the correct enumeration for the choosen framework.

A down side is... that if you include Blazorize.Bootstrap you will have to make a distinction because there will be some ambiguity. For Example < Card > wil become something like <Blazor.AdminLte.Card>. Respectively for Blazorise.Bootstrap wil become something like <Blazorise.Card> Although that is the primary intention for namespaces.

In otherwords different compontentization frameworks can be easily integrated through namespacing and work in unison.

@jbennink
Copy link
Contributor Author

jbennink commented Aug 13, 2020

Isn't project Site (and Site.Shared) the Site that you, the user, makes so taking a dependency there would be fine.? Blazorise.AdminLte is de source for the nuget package? Correct?
If you don't want to take a dependency on Blazorise.Bootstrap or whatever then you really can't create all of the controls that are part of the AdminLte template, or am I missing something here?

It's feels very cumbersome having duplicate components and types. The Buttons page used Card and Button. I removed my Button from UIElements but still prefixing Card, or button does not make switching compontentization frameworks very easy. And If you are going to need to change prefixes than you might be better of encapsulating components and hindg the compontentization framework dependancy there. But that feel like a lot of work.

Isn't AdminLte based on Bootstrap so you really can't use Material, AntDesign, or MatBlazor together with AdminLte?

…he default bootstrap controls. This means we do not support XtraSmall, Flat and Gradient Buttons
@jbennink
Copy link
Contributor Author

Are your intentions with Blazor.AdminLte to create only the controls not part of Blazorise?

Then I wonder why Card and Carousel were started. Those are already in Blazorise. I think that is not a bad Idea, even though my changed Buttons page now looks less clean because of all the namespaces. I guess I could alias some to make them easier to read.

@jbennink
Copy link
Contributor Author

To continue this discussion about project layout and how to separate things I have some more questions. Just curious and want to learn how other do things.

Question: Was I correct in adding the Blazorise dependency to the Site.Shared project?

Question: Is it correct to assume the Blazor.AdminLte.Site and Blazor.AdminLte.Site.Shared projects are "copied" and changed/used to create you "app" and the Blazor.AdminLte is taken as a nuget dependency?

Question: What is the reason to have a Blazor.AdminLte.Content project that has copied versions of all javascript libraries instead of using LibMan?

@sjefvanleeuwen
Copy link
Owner

@jbennink do you want a microsoft teams session? So we can take you through the concepts. That might be easier to explain.

@jbennink
Copy link
Contributor Author

jbennink commented Aug 13, 2020

@jbennink do you want a microsoft teams session? So we can take you through the concepts. That might be easier to explain.

Yep on my work email (j.bennink@calway.nl), no problem that probably works faster. Not sure if you are still online, but we could schedule for tomorrow otherwise. I will be going home around 18:15 today

@jbennink jbennink marked this pull request as ready for review August 13, 2020 16:12
@sjefvanleeuwen sjefvanleeuwen changed the base branch from master to buttons August 13, 2020 18:20
@sjefvanleeuwen sjefvanleeuwen changed the base branch from buttons to master August 13, 2020 18:20
@sjefvanleeuwen sjefvanleeuwen changed the base branch from master to buttons August 13, 2020 18:21
@sjefvanleeuwen sjefvanleeuwen merged commit 573cdd5 into sjefvanleeuwen:buttons Aug 13, 2020
@sjefvanleeuwen
Copy link
Owner

sjefvanleeuwen commented Aug 13, 2020

I have reached the same conclusion, in regards to missing styles on the blazorise bootstrap components. Your initial proposal is preferred. I have commited the initial proposal under 573cdd5#diff-25d902c24283ab8cfbac54dfa101ad31 and reverted blazorise for record might we choose to use blazorise under a46465c#diff-25d902c24283ab8cfbac54dfa101ad31

@sjefvanleeuwen sjefvanleeuwen self-assigned this Aug 13, 2020
@jbennink jbennink deleted the buttons branch August 14, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed question Further information is requested

2 participants