Skip to content

Add countAnsiEscapeCodes option #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2023
Merged

Add countAnsiEscapeCodes option #48

merged 5 commits into from
May 6, 2023

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented May 5, 2023 •
edited
Loading

Same as sindresorhus/string-length#16, add an option to count ANSI escape codes.
Previously requested by #15, and Prettier do need count them.
@fisker
Copy link
Contributor Author

fisker commented May 5, 2023

#47 should fix the CI.
@sindresorhus
Copy link
Owner

sindresorhus commented May 5, 2023

Can you fix the conflict?
@sindresorhus
Copy link
Owner

sindresorhus commented May 6, 2023

CI is failing:

 index.test-d.ts:5:36 ✖ 5:36 Argument of type { ambiguousIsNarrow: false; } is not assignable to parameter of type Options. Property countAnsiEscapeCodes is missing in type { ambiguousIsNarrow: false; } but required in type Options. ✖ 6:55 Argument of type { countAnsiEscapeCodes: true; } is not assignable to parameter of type Options. Property ambiguousIsNarrow is missing in type { countAnsiEscapeCodes: true; } but required in type Options. 2 errors
@fisker
Copy link
Contributor Author

fisker commented May 6, 2023

Fixed.
@sindresorhus sindresorhus merged commit 6e6993b into sindresorhus:main May 6, 2023
@fisker fisker deleted the countAnsiEscapeCodes branch May 6, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@fisker @sindresorhus