Added "until" cli option #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Looks good to me. Since it's a new flag, could you also add an example in the readme::usage section? |
| I added the following:
Under usage, right.... Ok, let me fix that. |
To go along with the new option listed under usage
| @simonrenoult I added a few examples of since/until usage in addition to the readme::usage flag option I previously added. Let me know if you want anything else! |
scottamplitude commented Aug 26, 2021
scottamplitude commented Aug 26, 2021
| LGTM! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since there are issues handling a large # of commits due to buffer overflow, I've added an until cli option to allow exporting an analysis for limited time windows.
Use case:
This is more of a work-around to the buffer overflow issue. Ideally, that issue should be addressed. This works in the meantime and allows for analyzing different historical windows.