Skip to content

Conversation

@pkuczynski
Copy link
Contributor

@pkuczynski pkuczynski commented Feb 6, 2025

Inspired by #3028

If this goes through I might work on a patch with ssl: true - depending on maintainers decision.

Copy link
Collaborator

@wellwelwel wellwelwel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pkuczynski 🙋🏻‍♂️

I've added some changes and also included a suggestion for AWS RDS certificates.

@wellwelwel wellwelwel linked an issue Feb 6, 2025 that may be closed by this pull request
@codecov

This comment was marked as off-topic.

@wellwelwel
Copy link
Collaborator

@pkuczynski, about the lint issue, you can run cd website && npm run lint to auto fix it after all changes 🤝

pkuczynski and others added 10 commits February 6, 2025 15:17
Co-authored-by: Weslley Araújo <46850407+wellwelwel@users.noreply.github.com>
Co-authored-by: Weslley Araújo <46850407+wellwelwel@users.noreply.github.com>
Co-authored-by: Weslley Araújo <46850407+wellwelwel@users.noreply.github.com>
Co-authored-by: Weslley Araújo <46850407+wellwelwel@users.noreply.github.com>
Co-authored-by: Weslley Araújo <46850407+wellwelwel@users.noreply.github.com>
# Conflicts: #	website/docs/documentation/ssl.mdx
@pkuczynski
Copy link
Contributor Author

All changes applied. Let me know if anything more shall be changed...

Copy link
Collaborator

@wellwelwel wellwelwel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixing a broken link 🙋🏻‍♂️

@wellwelwel wellwelwel merged commit a446fac into sidorares:master Feb 6, 2025
101 checks passed
@wellwelwel
Copy link
Collaborator

If this goes through I might work on a patch with ssl: true - depending on maintainers decision.

@pkuczynski, I think that's worth having its own issue. In my mind ssl: true was functional (and made more sense than ssl: {}).

@pkuczynski
Copy link
Contributor Author

If this goes through I might work on a patch with ssl: true - depending on maintainers decision.

@pkuczynski, I think that's worth having its own issue. In my mind ssl: true was functional (and made more sense than ssl: {}).

Yeah, this is exactly what I meant by saying I will work on it after aproval. So here it goes: #3387

@pkuczynski pkuczynski deleted the patch-1 branch February 8, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment