Skip to content

Conversation

@ntexe
Copy link
Contributor

@ntexe ntexe commented Sep 5, 2024

Fixed #2242. I added regex check to three sites that caused an error.
image

Copy link
Contributor Author

@ntexe ntexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a limit of 63 for label values, so i used {1,63} in regexCheck. However, smugmug clips username at 35 characters, so i used {1,35} in regexCheck.

Copy link

@RahulVadisetty91 RahulVadisetty91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r43

The regexCheck seems to allow only one character for the username, which is incorrect. It should likely allow multiple characters. To correct it

{
"errorType": "response_url",
"errorUrl": "https://booth.pm/",
"regexCheck": "^[a-zA-Z0-9@_-]$",
"url": "https://{}.booth.pm/",
"urlMain": "https://booth.pm/",
"username_claimed": "blue"
}

@ppfeister ppfeister self-assigned this Nov 4, 2024
@ppfeister ppfeister added bug Something isn't working false negative A site is responding with false negatives labels Nov 4, 2024
@ppfeister ppfeister merged commit 18bae48 into sherlock-project:master Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working false negative A site is responding with false negatives

3 participants