Skip to content

Conversation

@gustavosbarreto
Copy link
Member

@gustavosbarreto gustavosbarreto commented Oct 1, 2025

This pull request refactors the device notification system in the application header. The main change is the removal of the notifications menu and related notification logic, replaced with a new, feature-rich DevicesDropdown component that provides device management capabilities directly in the app bar. The codebase is simplified by eliminating notification-related components, stores, and adapters, and updating device action flows.

  • Replaced the NotificationsMenu in the app bar with a new DevicesDropdown component, which provides device statistics, pending device approvals, recent activity, and direct device management actions
  • Deleted notification-related components: NotificationsMenu.vue, NotificationsList.vue, notification interfaces (INotification.ts), notification store (notifications.ts), and notification adapters (notificationAdapters.ts)
  • Updated device action flows (DeviceActionButton.vue) and onboarding logic (Welcome.vue) to refresh device statistics instead of notifications after device approval/rejection

These changes streamline device management in the UI and simplify the codebase by removing notification logic.

@gustavosbarreto gustavosbarreto requested a review from a team as a code owner October 1, 2025 21:01
@gustavosbarreto gustavosbarreto marked this pull request as draft October 1, 2025 21:02
@otavio otavio requested a review from luizhf42 November 3, 2025 20:24
@luizhf42 luizhf42 force-pushed the feat/devices-dropdown branch 4 times, most recently from b426b40 to 58cfbf1 Compare November 5, 2025 12:33
@luizhf42 luizhf42 added kind/feature New feature or request area/ui labels Nov 5, 2025
@luizhf42 luizhf42 marked this pull request as ready for review November 5, 2025 12:41
@luizhf42 luizhf42 force-pushed the feat/devices-dropdown branch 2 times, most recently from b91d9b5 to ceb4ffb Compare November 5, 2025 13:20
@luizhf42 luizhf42 force-pushed the feat/devices-dropdown branch from ceb4ffb to 13b32b0 Compare November 5, 2025 14:36
@luizhf42 luizhf42 requested a review from otavio November 5, 2025 14:40
Co-authored-by: Luiz Henrique <luizhf42@gmail.com>
@luizhf42 luizhf42 force-pushed the feat/devices-dropdown branch from 13b32b0 to 805322b Compare November 5, 2025 14:42
@otavio otavio merged commit f3f9645 into master Nov 5, 2025
8 checks passed
@otavio otavio deleted the feat/devices-dropdown branch November 5, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants