Skip to content

Conversation

@icco icco marked this pull request as ready for review November 22, 2023 14:00
@vladholubiev
Copy link
Member

@harazdovskiy could you please take a look if nothing breaks, tests pass, and publish a new version?

@harazdovskiy harazdovskiy self-requested a review November 22, 2023 22:09
@harazdovskiy
Copy link
Contributor

Checked locally, merging! Thanks @icco for being patient and crafting this pull request❤️

CleanShot 2023-11-23 at 00 57 15@2x

@harazdovskiy harazdovskiy merged commit 09b0fd1 into shelfio:master Nov 22, 2023
@harazdovskiy
Copy link
Contributor

harazdovskiy commented Nov 22, 2023

@icco you can try changes in v4.2.0

@icco icco deleted the mongo6 branch November 23, 2023 16:01
@icco
Copy link
Contributor Author

icco commented Nov 23, 2023

Thank you!

@erosval
Copy link

erosval commented Nov 24, 2023

Thank you! Unfortunately, the test cases I implemented now no longer work as before when switching from mongodb driver 5.9.1 to 6.3.0.

I have several test cases and it would be complicated to report them but some queries return "undefined", does this happen to others too?

@icco
Copy link
Contributor Author

icco commented Nov 24, 2023

Thank you! Unfortunately, the test cases I implemented now no longer work as before when switching from mongodb driver 5.9.1 to 6.3.0.

I have several test cases and it would be complicated to report them but some queries return "undefined", does this happen to others too?

Did you follow Mongo's upgrade documentation? https://www.mongodb.com/docs/drivers/node/current/upgrade/#version-6.x-breaking-changes we're still rolling out, but some of the return objects have changed.

@erosval
Copy link

erosval commented Nov 24, 2023

Yes of course, when I run tests on a real mongodb database (v.7) everything works as expected

@icco
Copy link
Contributor Author

icco commented Nov 24, 2023

Interesting, I haven't seen that yet. Let's create a new issue and try and figure it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants