Update Layer to use @sparticuz/chromium #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Any chance that this PR will get merged anytime soon? I made a local commit that upgrades Chromium to v114, but I myself struggle to test the changes in my own project. |
| @stefanzweifel thanks for the bump, we'll take a look |
vladholubiev approved these changes Jul 19, 2023
| @stefanzweifel published as verion 32 |
| @vladgolubev Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updates the project to use
@sparticuz/chromiuminstead of@sparticuz/chrome-aws-lambda.Chromium itself has also been updated to v109.
This should fix #53.
I've deployed the layer to my own AWS account and could confirm that everything still works as intended.
(I've renamed
chrome_aws_lambda.ziptochromium.zip, as the artifcat name inSparticuz/chromiumalso changed.)