V3

[mongjong59]

No description provided.

[mongjong59]

Here if I wrote the following code, the linter would warn that I should use export default instead

export const updateName = (text) => ({ type: actionTypes.HELLO_WORLD_NAME_UPDATE, text, });

[mongjong59]

Linter will warn that I should use export default here as there's only one export. But if I did so, mapDisptachToProps related code in the container file (HelloWorld.jsx) would be weird. Should I create a dummy action here to bypass this warning or can we ignore this rule? I think the rule is not quite suitable in this kind of circumstances.

[justin808]

Add this line to the top of the file:

/* eslint-disable import/prefer-default-export */ 

[justin808]

@nostophilia Please make the following changes and create a v4 branch. We're close!

@robwise, @alexfedoseev please confirm my suggestions.

[justin808]

Add this line to the top of the file:

/* eslint-disable import/prefer-default-export */ 

[justin808]

remove mirrorCreator

Instead, use the simple form:

export default { HELLO_WORLD_NAME_UPDATE: 'HELLO_WORLD_NAME_UPDATE' }; 

So this file just has above lines..

@alexfedoseev Please confirm

[alex35mil]

I'd use

export const HELLO_WORLD_NAME_UPDATE = 'HELLO_WORLD_NAME_UPDATE';

[robwise]

Agree with Alex

[justin808]

this file should be helloWorldReducer.js and not name.jsx

[justin808]

Let's use this for the initial state:

{ name: '' } 

It's really confusing for me with a single value for the reducer.

Also, we can use the spread operator for the reducer

return { ...state, name: text } 

to ensure we don't mutate state.

@robwise, @alexfedoseev please confirm

[alex35mil]

👍

[robwise]

It's standard practice to write reducers with single values like that and is in the basic Todos example from Redux

[mongjong59]

Yeah. Because combineReducers is used in index.js, so the intialState is actually:

{ name: '' } 

I think it's better to use combineReducers and child reducer to handle a simple slice of state. So I suggest have a name reducer in helloWorldReducer.js and also call combineReducers in this file.

[justin808]

export default helloWorldReducer;