Server rendering example #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* TEMP COMMIT for pairing... * Path for react-rails is ~/a/react-rails TIME TO HACK! commit 7cacc8a5206d22cd480b657bb85b47bb45e02e04 Merge: e8ced3b 88dad94 Author: Justin Gordon <justin.gordon@gmail.com> Date: Mon Jul 13 18:39:37 2015 -1000 Merge branch 'server-rendering' of https://github.com/nikhilbaradwaj/react-webpack-rails-tutorial into nikhilbaradwaj-server-rendering * 'server-rendering' of https://github.com/nikhilbaradwaj/react-webpack-rails-tutorial: capybara-webkit was removed by mistake because I could not install this gem for some reason. Minor changes to App.jsx React-rails gem and setup for server side rendering. commit 5572adf Author: Nikhil Baradwaj <nikhilbaradwaj@gmail.com> Date: Mon Jul 13 21:56:57 2015 -0400 React-rails gem and setup for server side rendering.
* not working * getting error on the document thing * Need to make sure that webpack global export is done correctly * If we export the App component globally, then that should not conflict with anything. * Once we can export the App component, then we can pass in the comments as JSON, so it server renders.
| See #59. Server rendering will be included with that change. |
| Not going to do it this way. See https://github.com/shakacode/react_rails_server_rendering/ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
WIP right now.