Skip to content

update ENV variable for react_on_rails 8 #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2017
Merged

update ENV variable for react_on_rails 8 #401

merged 1 commit into from
Jul 17, 2017

Conversation

@kevinhughes27
Copy link
Contributor

@kevinhughes27 kevinhughes27 commented Jun 21, 2017 •
edited by justin808
Loading

as discussed here: #395 this ENV variable was changed with the move to react_on_rails 8 and webpacker lite.

@justin808

This change is Reviewable
@justin808
Copy link
Member

justin808 commented Jul 3, 2017

LGTM @kevinhughes27. However, CI is not passing. I restarted the CI. Please take a look.
@kevinhughes27
Copy link
Contributor Author

kevinhughes27 commented Jul 4, 2017

Looks like issues with PhantomJS Exception caught! Capybara::Poltergeist::DeadClient. Is this how the tests normally fail if there are issues?
@justin808 justin808 merged commit 102745f into shakacode:master Jul 17, 2017
@justin808
Copy link
Member

justin808 commented Jul 17, 2017

Thanks @kevinhughes27!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@kevinhughes27 @justin808