Docker support to run the project

[sub2u]

This change is

[sub2u]

Referring to #331

[justin808]

@dylangrafmyre Can you please review this one.

[dylangrafmyre]

@sub2u Could you please link to your sub2u/ruby-2.3.1-node-6.8.0 Dockerfile. I do not see it on Docker Hub. Is it in a Github repo?

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[sub2u]

@dylangrafmyre You can find the docker in docker hub
https://hub.docker.com/r/sub2u/ruby-2.3.1-node-6.8.0/

[dylangrafmyre]

@sub2u there is no Dockerfile tab under your referenced docker hub repo.

---

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from Reviewable

[sub2u]

@dylangrafmyre Docker file is in github repo please review in https://github.com/sub2u/ruby-2.3.1-node-6.8.0

[alex35mil]

Wouldn't it be more convenient to mount directory instead of coping over all the things inside container?

[sub2u]

Sure, we can use ADD, i will update it

[alex35mil]

I was meaning not ADD, but volumes. Copying process takes time and in development copy files on change is kinda pricy. If volume is used, then it reads the files directly from the mounted volume, so it should be faster.

[alex35mil]

@sub2u IMO you have too many layers in https://github.com/sub2u/ruby-2.3.1-node-6.8.0

Your stuff will be outdated if you will change something below RUN apt-get update -qq ... as this layer is cached by the docker and will be reused.

[sub2u]

@alexfedoseev we can use force update, in RUN apt-get update -qq but j am not sure if will effect the build performance it always try to get updates instead of fetching from caching layer.

[alex35mil]

we can use force update, in RUN apt-get update -qq but j am not sure if will effect the build performance it always try to get updates instead of fetching from caching layer.

If it acts like this then I believe there's something wrong is going on w/ this setup as unchanged layer must be taken from the cache: https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#/minimize-the-number-of-layers

[dylangrafmyre]

@sub2u Thank you for taking the time to work on this. For this project I think it would be best to have a project Dockerfile that we maintained off of the the Ruby 2.3.1-alpine base image or similar. I do not think it is best to rely on a maintained image by contributors to this project.

@alexfedoseev brings up very good points about image size and minimizing image layers.

I would be more than happy to work on getting the right Dockerfile config and build in place with you that meets the needs of this tutorial.

---

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[sub2u]

Sure @dylangrafmyre i will update the docker file

[sub2u]

Yes agreed Image size should be less,

It contain All Ruby nodejs, and other libraries required for project it is 366 MB size.
I will prepare the docker file with volume to link from external volumes.

On 25-Oct-2016, at 11:10 am, Dylan Grafmyre notifications@github.com wrote:

@sub2u https://github.com/sub2u Thank you for taking the time to work on this. For this project I think it would be best to have a project Dockerfile that we maintained off of the the Ruby 2.3.1-alpine base image or similar. I do not think it is best to rely on a maintained image by contributors to this project.

@alexfedoseev https://github.com/alexfedoseev brings up very good points about image size and minimizing image layers.

I would be more than happy to work on getting the right Dockerfile config and build in place with you that meets the needs of this tutorial.

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable https://reviewable.io/reviews/shakacode/react-webpack-rails-tutorial/332#-:-KUuJbtl_TcgA6H3x0x4:b-fisakc
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #332 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAnncBLhlqSRr1GBug6EdmJDnZ-f6HPXks5q3ZZWgaJpZM4KfIuR.

[justin808]

@sub2u Any update?

[justin808]

@sub2u Anything I can do to help?