Eslint #320
Merged
Eslint #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These rules can be safely removed: - no-undef - space-before-function-paren - indent - id-length - jsx-quotes - react/display-name - react/jsx-boolean-value - react/jsx-curly-spacing - react/jsx-no-duplicate-props - react/jsx-no-undef - react/jsx-sort-prop-types - react/jsx-sort-props - react/jsx-uses-react - react/jsx-uses-vars - react/no-danger - react/no-did-mount-set-state - react/no-did-update-set-state - react/no-multi-comp - react/no-unknown-property - react/prop-types - react/react-in-jsx-scope - react/self-closing-comp - react/jsx-wrap-multilines - react/sort-comp [rules/react.yml#L5](https://github.com/shakacode/style-guide-javascript/blob/master/packages/eslint-config-shakacode/rules/react.yml#L5) - no-unused-vars [rules/javascript.yml#L14](https://github.com/shakacode/style-guide-javascript/blob/66a6c7100c4/packages/eslint-config-shakacode/rules/javascript.yml#L14)
|
OUTSTANDING Reviewed 6 of 6 files at r1. Comments from Reviewable |
AlexKVal added a commit to AlexKVal/react-webpack-rails-tutorial that referenced this pull request Aug 15, 2016
And resolve eslint warnings because of Eslint (shakacode#320)
justin808 pushed a commit that referenced this pull request Aug 21, 2016
* Show details for errors on the "Simple React" page. * Only for "Horizontal Form" and "Stacked Form" * Fix. Clean error alert up after a successful submission. * Add validation styles for input elements * Fix error propagation for "React Demo" page * And resolve eslint warnings because of Eslint (#320) * Add Capybara specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #319
I've made three commits to facilitate review process:
_nametoname.After reviewing the PR I'll squash (or who will merge) them into one
Clean up js code linting rulescommit.There is no need to change eslint-config-shakacode/README.md
This change is