Skip to content

fix lint and require issues causing 'bin/rake ci' to fail #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2016
Merged

fix lint and require issues causing 'bin/rake ci' to fail #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec/rails_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
require "rspec/rails"
require "capybara/rspec"
require "capybara-screenshot/rspec"
require "database_cleaner"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is odd -- are we sure this is needed?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, it blew up for me on a clean rake ci of master until I added this. If it didn't on travis or for you, there's something non-deterministic.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait to see if other's report this.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a problem for me against latest master. I don't know what else is requiring database cleaner without this line. If it works for you, I'd be interested in seeing what requires it if you put a raise at the top of the database cleaner gem entry point file and post the stacktrace.

# Add additional requires below this line. Rails is not loaded until this point!

Expand Down