Skip to content

Conversation

@aaronvb
Copy link
Member

@aaronvb aaronvb commented Feb 17, 2016

Fixes #228

Review on Reviewable

justin808 added a commit that referenced this pull request Feb 17, 2016
@justin808 justin808 merged commit 495956c into shakacode:master Feb 17, 2016
@justin808
Copy link
Member

Thanks @aaronvb.

Are you sure we picked up any differences in the linter setups?

@aaronvb
Copy link
Member Author

aaronvb commented Feb 17, 2016

@justin808 Which setups? Airbnb and the shakacode config?

@justin808
Copy link
Member

  1. Ensuring that we're using any overrides from the shakacode config on npm.
  2. We should possibly update the shakacode one to depend on the latest airbnb one.
@aaronvb
Copy link
Member Author

aaronvb commented Feb 18, 2016

@justin808 I tested and confirmed that is it adding the override configs from the eslint-shakacode-config, although right now there aren't any overrides. Also, the eslint-shakacode-config extends the airbnb config.

@justin808
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants