Skip to content

fix lodash find syntax to return correct csrf-token content #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2016
Merged

fix lodash find syntax to return correct csrf-token content #209

merged 1 commit into from
Jan 25, 2016

Conversation

@marcusvmsa
Copy link
Contributor

Review on Reviewable
@marcusvmsa marcusvmsa mentioned this pull request Jan 25, 2016
Closed
@justin808
Copy link
Member

:lgtm_strong: 👏

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

client/app/libs/metaTagsManager.js, line 11 [r1] (raw file):
https://lodash.com/docs#find

// using the `_.matchesProperty` iteratee shorthand _.find(users, ['active', false]); // → object for 'fred'

Comments from the review on Reviewable.io
@justin808
Copy link
Member

@robwise @MaMute we need to put this helper into npm react-on-rails!

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io
justin808 added a commit that referenced this pull request Jan 25, 2016
@justin808
Merge pull request #209 from mamute/fix-lodash-find-syntax-on-meta-ta…
1c6cc0c 
…gs-manager fix lodash find syntax to return correct csrf-token content
@justin808 justin808 merged commit 1c6cc0c into shakacode:master Jan 25, 2016
@enterstudio enterstudio mentioned this pull request Nov 5, 2022
Open
@enterstudio enterstudio mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@marcusvmsa @justin808