Set comment's author and text as not null and defaults as empty string #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The last parameter of change_column_null only affects existing records, thus the default still needs to be set in another migration.
| @justin808 Ready for review. |
There was a problem hiding this comment.
Why 2 migrations?
Does change_column_null handle migrating old records? We might need a couple lines of SQL to update the existing records. Then again, there probably aren't any, or else the UI would have crashed.
There was a problem hiding this comment.
Well, yes, that last parameter (empty string) of change_column_null replaces null values of existing records, so we don't need SQL statements here.
But it still doesn't set the column's default for new records, thus we do need a second migration to change_column_default.
justin808 added a commit that referenced this pull request Oct 15, 2015
Set comment's author and text as not null and defaults as empty string
| Thanks @josiasds |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The last parameter of
change_column_nullonly affects existing records, thus the new default value still needed to be set bychange_column_default.Fixes #110.