fix(hover-card,tooltip): add missing portal for hover card and tooltip #5409
+38 −32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
| Hi @shadcn, wondering if you could review again? |
| Just ran into this issue where our hovercard content was being masked by the parent element and adding the missing portal fixed it for us so it would be great to get this merged upstream for others so they don't run into the same problem |
| @jonioni it does look like you missed the new york variant of the hovercard though |
| Ran into this again today, would love to see this get merged |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes: #1984, #1940
Add
<*.Portal>wrapper for<HoverCard>and<Tooltip>to anchor the popped menu.