Skip to content

Conversation

@wwwzbwcom
Copy link
Contributor

No description provided.

@wwwzbwcom wwwzbwcom changed the title refactor: metric refactor to TypeScript refactor: metrics refactor to TypeScript Feb 19, 2021
export { default as Vpc } from './modules/vpc';
export { default as Cam } from './modules/cam';
export { default as Metrics } from './modules/metrics';
export { default as Metrics } from './modules/metrics/index';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一样改动有啥影响吗?

apiDetail = await this.getApiById({ serviceId: serviceId!, apiId: endpoint.apiId });
}

if (!apiDetail!) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面的 ! 符号没必要


if (apiDetail) {
console.log(`Api method ${endpoint.method}, path ${endpoint.path} already exist`);
if (apiDetail && endpoint) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看看试着把 endpoint 参数改为必须

@wwwzbwcom wwwzbwcom merged commit d0c4d48 into master Feb 19, 2021
@wwwzbwcom wwwzbwcom deleted the refactor/metric-refactor branch February 19, 2021 07:56
@slsplus
Copy link
Collaborator

slsplus commented Feb 19, 2021

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants