Skip to content

Conversation

@dodgeblaster
Copy link
Contributor

No description provided.

@eahefnawy
Copy link
Member

Thanks @dodgeblaster ... thinking about it a bit deeper. What is the behavior that you would expect if a user changed the name input? 🤔

@dodgeblaster
Copy link
Contributor Author

dodgeblaster commented Aug 27, 2019

I added a check to see if:

  • last deploy had no name defined, and current deploy has no name defined
    or
  • last deploy had name defined, and current deploy has the same name defined

If not, it will go to the 'delete and create' branch of the if statement. It is keeping track of state through this.state. Will that be an issue for CI deploys? I am unfamiliar how state works in a CI context

@dodgeblaster
Copy link
Contributor Author

@eahefnawy Made a few additional commits. Should be ready to be reviewed now.

Copy link
Member

@eahefnawy eahefnawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dodgeblaster

@eahefnawy eahefnawy merged commit 0be1baf into serverless-components:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants