Skip to content

CI/CD and other maintance improvements #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
medikoo merged 18 commits into from
Jul 1, 2020
Merged

CI/CD and other maintance improvements #15

medikoo merged 18 commits into from
Jul 1, 2020

Conversation

@medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 30, 2020 •
edited
Loading

  • Configure CI/CD with following steps:
    • On PR: Validate lint & prettier
    • On push to master:
      • Publish "dev" version
      • Run integration tests, to confirm "dev" version works ok
      • If version was bumped in serverless.component.yml issue a release tag
    • On release tag: Publish new version
  • Upgrade lint & prettier configuration to @serverless/eslint-config
  • Ensure to install all nested packages on npm install
  • Commit in src/package-lock.json to ensure reproducible component (at given version) installs
  • Cleanup package.json from npm registry related information (as it's not intended to be published to npm)
  • Move tests to test folder, as it's more common name by general conventions
  • Cleanup .gitignore (https://gist.github.com/subfuzion/db7f57fff2fb6998a16c)
  • Introduce .editorconfig
@medikoo medikoo self-assigned this Jun 30, 2020
eahefnawy
eahefnawy reviewed Jul 1, 2020
View reviewed changes
README.md Outdated
name: my-table # (required) name of your instance.
org: serverlessinc # (optional) serverless dashboard org. default is the first org you created during signup.
app: myApp # (optional) serverless dashboard app. default is the same as the name property.
stage: dev # (optional) serverless dashboard stage. default is dev.
Copy link
Member

@eahefnawy eahefnawy Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gonna get ugly. Linting sometimes just doesn't make sense.
Copy link
Contributor Author

@medikoo medikoo Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's prettier not linter that reformatted it.

Anyway I turned off prettification of markdown, as indeed it's not what we want here, and there's no way to enforce Prettier to respect that
@medikoo medikoo merged commit 50c3c25 into master Jul 1, 2020
@medikoo medikoo deleted the 0630-cicd branch July 1, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@medikoo @eahefnawy