Fix typings with ESM #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @reconbot any reasons why this fix is not merged? :( |
| Could we please get this fix merged. |
| Just came across this issue today, thank you to @flaviut for finding the fix, seems to work fine but i agree this should be merged already. |
| Dear SerialPort team, please merge the pull request! Thank you. |
JulianWowra approved these changes Jul 26, 2025
| Nobody cares, this is fact. Just use pnpm patch // But anyway this is lib awesome |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Without this change, I get this error:
Once this change is made, everything typechecks correctly.