Skip to content

Conversation

@mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented May 16, 2025

Fixes #529

I am not familiar with the deepdiff codebase, I wouldn't know how or where to best integrate this feature. It was an LLM who proposed where. Please comment whether it should be done differently.

Also I have only tested this in linux and mac. I don't know if it works in windows. But an LLM said to use colorama, which is why that is in deepdiff/colored_view.py, but not tested.

@mauvilsa
Copy link
Contributor Author

Now I added a colored compact view to have both options proposed in #529.

@mauvilsa
Copy link
Contributor Author

We have identified some bugs, so changing this to draft.

@mauvilsa mauvilsa marked this pull request as draft May 22, 2025 07:40
@seperman
Copy link
Owner

Hi @mauvilsa
Looks exciting! Ok please ping me when ready. :)

@mauvilsa
Copy link
Contributor Author

@seperman I have fixed the bugs that we had noticed. You can review now.

@mauvilsa mauvilsa marked this pull request as ready for review May 28, 2025 12:36
@seperman
Copy link
Owner

Hey @mauvilsa Thanks for fixing the bugs. Sorry I have been slow in reviewing. I will take care of it by the end of the week.

@seperman seperman changed the base branch from master to dev July 2, 2025 20:02
Copy link
Owner

@seperman seperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool! I love how you kept the tree view for repr but when converting to strings, it has colors. Thank yoU!

@seperman seperman merged commit 1c30c5a into seperman:dev Jul 2, 2025
@seperman
Copy link
Owner

seperman commented Jul 2, 2025

@mauvilsa LGTM! merging.

@mauvilsa mauvilsa deleted the colored-view branch July 3, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants