Fix broken DeepDiff for dateutils.rrules (#355) #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
seperman requested changes Nov 8, 2022
Owner
seperman left a comment
seperman left a comment There was a problem hiding this comment.
Hi @uwefladrich
Thanks for the PR. Left a comment.
Also please add your name and github handle to the AUTHORS.md file.
seperman reviewed Nov 8, 2022
Owner
| @uwefladrich dateutils needs to be in the |
Contributor Author
| Hi @seperman , is there anything I can/should do for this PR at the moment? It seems to be waiting for approval... |
Owner
| @uwefladrich Thanks for the reminder. |
Codecov Report
@@ Coverage Diff @@ ## dev #356 +/- ## ========================================== - Coverage 99.42% 99.39% -0.04% ========================================== Files 14 14 Lines 3143 3143 ========================================== - Hits 3125 3124 -1 - Misses 18 19 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Owner
| @uwefladrich Merged. Thanks for contributing to DeepDiff. I will ping you once I cut a release. |
Contributor Author
| Great, thanks for considering it! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix problem with diff'ing
dateutils.rrules, but potentially other non-sequence iterables. The underlying issue is that DeepDiff sends objects todifflib.SequenceMatcherwithout checking that they are actually sequences.