Skip to content

feat(client): Add generic typing to @sendgrid/client request function #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sashko9807 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(client): Add generic typing to @sendgrid/client request function #1399

sashko9807 wants to merge 1 commit into from

Conversation

@sashko9807
Copy link

@sashko9807 sashko9807 commented May 24, 2024 •
edited
Loading

Fixes

  • Made request function generic, so we can get correct response body type definitions.
  • Made ClientResponse generic.
  • Made ClientRequest generic.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified
@sashko9807
feat(client): Add generic typing to @sendgrid/client request function
643bc1d 
- Made request function generic, so we can get correct response body. - Made ClientResponse generic - Made ClientRequest generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@sashko9807