Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

Conversation

@mptap
Copy link

@mptap mptap commented Oct 28, 2017

Fixes #57

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Refactored unittest to check for specific repo files to use assert

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@mbernier edit - removed extra '#' in title

@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017

CLA assistant check
All committers have signed the CLA.

@mbernier
Copy link
Contributor

@mptap I have to apologize, I know you signed the CLA on another of our repos, but our legal team is funny and would like people to sign it for each repo they contribute to. Is that OK?

@mptap
Copy link
Author

mptap commented Oct 28, 2017

@mbernier: No worries, I understand :) Signed.

Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing on a line that I don't think exists... https://travis-ci.org/sendgrid/nodejs-http-client/jobs/294205946
Can you please check this and see if there is a typo somewhere?

/home/travis/build/sendgrid/nodejs-http-client/test/test.js:323

Thank you!

@mptap
Copy link
Author

mptap commented Oct 28, 2017

@mbernier: Whoops, had a missing closing brace, updated.

@mbernier
Copy link
Contributor

I merged in the master branch, because I believe most of the files we're checking for exist now :)

@mptap
Copy link
Author

mptap commented Oct 31, 2017

@mbernier: Not sure I understand - I don't think this is merged yet. Also, I have signed the CLA.

@mbernier
Copy link
Contributor

@mptap due to (kind of silly reasons) each repo requires that you sign the CLA, is that OK?

For the merge - I did a merge of the master branch and let it build again, So I could see your code checking the files that other people had added from this list in this issue!

@mptap
Copy link
Author

mptap commented Oct 31, 2017

@mbernier: I see. I've signed the CLA for this repo though - when I click on it, it says You have signed the CLA for sendgrid/nodejs-http-client. Tried clicking on Let us recheck it - no joy.

@mbernier
Copy link
Contributor

mbernier commented Nov 1, 2017

I think that it was "stuck" - looks good now. Thank you!!

@mbernier mbernier merged commit e41ab40 into sendgrid:master Nov 1, 2017
@thinkingserious
Copy link
Contributor

Hello @mptap,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title Refactored unittest to check for specific repo files to use assert chore: Refactored unittest to check for specific repo files to use assert Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.