Skip to content

Conversation

@Chirag-S-Kotian
Copy link

Overview:

This PR adds a "Home" link to the header, making it easier for users to navigate back to the homepage from any page of the application. This enhancement improves the overall user experience by providing a simple, visible link to return to the first page.

Changes Made:

  • Added a new "Home" link in the header next to the "Feedback" link.
  • The link redirects users to the root path (/), which serves as the homepage of the app.
  • No breaking changes introduced, as the change is purely UI-based.

Context:

The feature request was inspired by a similar implementation used in Semaphore templates. It addresses issue #74, which aimed to improve the ease of navigation for users.

Testing:

  • Verified that the "Home" link appears in the header.
  • Clicked on the "Home" link from various pages to confirm it redirects to the homepage.
  • No issues or errors encountered during testing.

This PR should be ready to merge. Thank you for reviewing! 🎉


@Chirag-S-Kotian
Copy link
Author

HI PLEASE REVIEW THIS PR

@vplasencia
Copy link
Member

vplasencia commented Oct 21, 2024

Hey @Chirag-S-Kotian! Thank you very much for the PR. This issue is related to the Semaphore boilerplate (semaphore-protocol/boilerplate#74) and the idea is to add the new link there. The link is already part of the templates.

The name of the link should be the name of the app which is Feedback. The new link would be something like this:

 <Link href="/" ml="2" textDecoration="none" _hover={{ textDecoration: "none" }} _focus={{ textDecoration: "none" }} > Feedback </Link>

Then this section (https://github.com/semaphore-protocol/boilerplate/blob/main/apps/web-app/src/components/PageContainer.tsx#L30-L49) will be something like this:

 <HStack align="center" justify="space-between" p="2"> <Link href="/" ml="2" textDecoration="none" _hover={{ textDecoration: "none" }} _focus={{ textDecoration: "none" }} > Feedback </Link> <HStack> <Link href={getExplorerLink( process.env.NEXT_PUBLIC_DEFAULT_NETWORK as string, process.env.NEXT_PUBLIC_FEEDBACK_CONTRACT_ADDRESS as string )} isExternal > <Text> {shortenString(process.env.NEXT_PUBLIC_FEEDBACK_CONTRACT_ADDRESS as string, [6, 4])} </Text> </Link> <Link href="https://github.com/semaphore-protocol/boilerplate" isExternal> <IconButton aria-label="Github repository" variant="link" py="3" color="text.100" icon={<Icon boxSize={6} as={FaGithub} />} /> </Link> </HStack> </HStack>

Could you close this PR and create a new PR with the changes in the Semaphore boilerplate repo: https://github.com/semaphore-protocol/boilerplate

@vplasencia
Copy link
Member

Hey @Chirag-S-Kotian!

Would you like to work on this issue in the Semaphore boilerplate repo? If so, please add a comment in the issue (semaphore-protocol/boilerplate#74) so that we can assign it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants