method __str__() from UserAgent now using methods custom get_device, get_os and get_browser #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Is better to calculate and provide a method to calculate the string values for `device`, `os` and `browser` instead of doing it directly on `__str__` method. This way the users may use those methods to get each data directly. Instead of having to make a `user_agent.__str__().split('/')` to get each value 
Contributor Author
Owner
| Thanks! |
Contributor Author
| @selwin When will be released a new version with this change? Waiting to modify my use of this lib 😬 |
Owner
Owner
| 2.2.0 is up on PyPI. https://pypi.org/project/user-agents/ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Is better to calculate and provide a method to calculate the string values for
device,osandbrowserinstead of doing it directly on__str__method.This way the users may use those methods to get each data directly. Instead of having to make a
user_agent.__str__().split('/')to get each value.