Add Chromebook detection as a "pc" #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @selwin any chance this could be reviewed or shall I work off my fork? |
Owner
| Thanks for the PR. Could you please change the check for ChromeOS to look at |
Contributor Author
| @selwin done |
| @selwin Are you going to merge this any time soon? |
| I'd love to see this merged too. Was just investigating how to make the patch myself then thought to see if someone else had done it already. |
Owner
| Thanks for the PR and sorry for the delay. Will try to tag a new release sometime in the next few days. |
| Hi, just checking in on timing for a release to get this great fix into the people's hands. |
Owner
| @asalant I just release version 1.1.0 on PyPI. Check it out and let me know if it works. |
| Thanks! …On Thu, Feb 16, 2017 at 2:49 PM, Selwin Ong ***@***.***> wrote: @asalant <https://github.com/asalant> I just release version 1.1.0 on PyPI. Check it out and let me know if it works. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGwuCuYj_ue_OVfEl-GTjJYIvNX_FHCks5rdNJugaJpZM4LS6Dj> . |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Given Chromebooks are laptops, treat them as is done for MacBooks - "PC" category.
The new test for this passes but pre-existing test for iPad is failing.