Relax "Windows RT" checks for devices that are "Windows RT 8.1" #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| Thanks for the PR! |
selwin added a commit that referenced this pull request Jan 30, 2015
Relax "Windows RT" checks for devices that are "Windows RT 8.1"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Windows tablets are not detected as being "touch capable" or "tablet", which obviously is wrong.
Maybe this could be fixed at a lower level in
ua_parserpackage, but the regexp with its os replacement is explicitly stating the version, so I guess it was the intention.