Fix: The SCH- check was erroneously setting Galaxy S phones to tablets. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Added support for PlayStation, PlayStation Vita, and SAMSUNG-GT-S8530.
Added test for Samsung Galaxy S5. Added test for Nexus 5.
selwin added a commit that referenced this pull request Sep 26, 2014
Fix: The SCH- check was erroneously setting Galaxy S phones to tablets.
Owner
| This is an excellent pull request! Thanks for working on this :) |
Contributor Author
| Thanks for the merge! I meant to split it up but I'm glad everything worked out :). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
We ran into a problem where Galaxy S phones where being erroneously detected as desktop devices. I also added support for PlayStation, PlayStation Vita and Bada devices. I believe the updates to the tablet device families make the SCH- check unnecessary. Please let me know if you have any questions or concerns.
Thank you,