This repository was archived by the owner on Jun 8, 2021. It is now read-only.
add redis.Conn type as a foundation for refactoring the implementation #21
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hey guys, this is a work in progress on refactoring the internals of the library to get a more solid support for transactions than we had until now. The idea is to have a low-level abstraction representing a client or server connection which exposes building block operations on top of which we'll be able to power the higher level APIs currently exposed by the package.
Support for basic commands and transactions on the client side is implemented right now. I'm still in the process of adding more tests, especially for the failure cases of redis transactions which not very consistent.
I've tried to document as much as possible but because of the short time frame it may still be a little rough, parallel with the redis documentation on the request/response and transactions if anything seems a bit obscure, at a high level here are the additions:
This is also going to be the foundations for the work I'll be doing tomorrow to focus on the PUB/SUB case.