Skip to content

Fix: invalid Cache-Control directives for REST package #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Fix: invalid Cache-Control directives for REST package #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions rest/jersey2/src/main/java/org/seedstack/seed/rest/jersey2/internal/CacheControlFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ public void configure(ResourceInfo resourceInfo, FeatureContext featureContext)
}

private static class CacheResponseFilter implements ContainerResponseFilter {
private static final String MUST_REVALIDATE_PRIVATE = "must revalidate, private";
private final CachePolicy policy;

CacheResponseFilter(CachePolicy policy) {
Expand All @@ -63,9 +62,19 @@ public void filter(ContainerRequestContext requestContext,
switch (this.policy) {
case NO_CACHE:
MultivaluedMap<String, Object> headers = responseContext.getHeaders();
headers.putSingle(HttpHeaders.LAST_MODIFIED, new Date());
Copy link
Member

@Sherpard Sherpard Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this header was intended?
Copy link
Member

@adrienlauer adrienlauer Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is intentional because this header is only making sense when you want to actually cache the resource.
headers.putSingle(HttpHeaders.EXPIRES, -1);
headers.putSingle(HttpHeaders.CACHE_CONTROL, MUST_REVALIDATE_PRIVATE);

// HTTP Caching is a tough subject thanks to the diversity of clients (browser and cache/proxy servers)
// See below a pretty good reference on HTTP Caching:
// https://stackoverflow.com/questions/49547/how-to-control-web-page-caching-across-all-browsers

// For client that doesn't support newer `Cache-Control` HTTP header
// https://tools.ietf.org/html/rfc7234#section-5.3
headers.putSingle(HttpHeaders.EXPIRES, 0);

// https://tools.ietf.org/html/rfc7234#section-5.2.2
// Theoretically, `no-store` only would be sufficient
// But for compatibility-purpose, adding other related headers doesn't hurt
headers.putSingle(HttpHeaders.CACHE_CONTROL, "no-store, no-cache, must-revalidate, private");
break;
case CUSTOM:
break;
Expand Down