Skip to content

Conversation

@Sherpard
Copy link
Member

@Sherpard Sherpard commented Aug 3, 2017

Retrieves if a user has already logged in a previous session

Retrieves if a user has already logged in a previous session
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f49c17c on Sherpard:feature/RememberMeInfo into ** on seedstack:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 16694ac on Sherpard:feature/RememberMeInfo into ** on seedstack:master**.

@adrienlauer
Copy link
Member

adrienlauer commented Aug 3, 2017

I think it could be better if just checking the isRemembered on the subject, so client code could combine the isAuthenticated() and isRemembered() checks at will. The method could then be renamed to the straightforward isRemembered().

Or maybe I'm missing some point, @Sherpard ?

@Sherpard
Copy link
Member Author

Sherpard commented Aug 3, 2017

That gives flexibility but also some incoherence, you can be Authenticated, but not Remembered.

But you have a point on that, I'll make the modification ASAP and update the PR :)

It only handles IsRemembered instead of IsRemembered and IsAuthenticated
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 282cf6b on Sherpard:feature/RememberMeInfo into ** on seedstack:master**.

@adrienlauer adrienlauer merged commit 282cf6b into seedstack:master Aug 3, 2017
@Sherpard Sherpard deleted the feature/RememberMeInfo branch August 9, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants