Fix interface selection for IPv6-only hosts #4380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Instead of considering the full IPv4 routing table, we only look for IPv4 default route and IPv6 routes shorter or equal /8 (for instance `2000::/3`). Since the `conf.route6` is not ready yet when we first run, we reload `conf.ifaces` after loading `route6.py`. This fixes secdev#4304 Signed-off-by: Ondřej Caletka <ondrej@caletka.cz>
oskar456 force-pushed the fix_get_working_if branch from 8424b89 to f655438 Compare | I just noticed that the same issue is being fixed already in #4321 so closing this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Instead of considering the full IPv4 routing table, we only look for IPv4 default route and IPv6 routes shorter or equal /8 (for instance
2000::/3). Since theconf.route6is not ready yet when we first run, we reloadconf.ifacesafter loadingroute6.py.This fixes #4304.
Checklist:
cd test && ./run_testsortox)fixes #4304