Skip to content

Conversation

@octref
Copy link
Contributor

@octref octref commented Sep 11, 2017

Sorry somehow this slipped off my todo-list 😅

Changes:

  • Split snippets into multiple files, corresponding to the README list. They are in the same order now so easier to maintain.
  • vue snippet only has vbase, which is available outside <template>, <script> and <style>
  • Snippets in vue-template.json are available for both Vue files (only in <template> section) and html files.
  • Snippets in vue-script.json and vue-script-vuex.json are availble for both Vue files (only in <script> section) and js files.
  • vinc and vdec seems to be for js instead of plaintext, so I moved them to the correct place in Readme.
@artiescie
Copy link

Works better, I guess the dependency (vetur) made a change that causes this issue in the snippets since it was clearly working at one point.

I would suggest one more "", in the vbase snippet... to add a newline after the closing <style> tag. That makes the stricter ESLint (rule eol-last) happy that the file ends with a newline.

@sdras
Copy link
Owner

sdras commented Sep 29, 2017

Thanks for the PR, it's too bad vetur is causing this issue, but I should be able to take a look sometime after this weekend.

@sdras sdras merged commit 70f6b17 into sdras:master Oct 14, 2017
@sdras
Copy link
Owner

sdras commented Oct 14, 2017

Finally had a day off from speaking! Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants