Refresh the excluded implementation #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rolandtritsch commented Jul 3, 2022
rolandtritsch commented Jul 3, 2022
rolandtritsch commented Jul 3, 2022
rolandtritsch commented Jul 3, 2022
ckipp01 requested changes Jul 4, 2022
There was a problem hiding this comment.
Thanks for the pr! I've left a few comments. Note that there is also compilation issues that need to be taken care of before CI can run.
Therefore I am thinking to add a coverageExclude task to sbt-scoverage that will rewrite/cleanup the scoverage.coverage file (remove the excluded packages, classes, files).
My gut reaction is that this isn't a good idea. Feel free to create an issue about it in the sbt repo, and we can discuss there.
ckipp01 approved these changes Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi @ckipp01,
my name is Roland Tritsch. Thanks for all the hard work on making scoverage work (again) for Scala3.
I also need this and will spend some time on this over the next couple of weeks and will start to send PR's your way.
I will try to keep the PR's small. But that also means there will be more of them. Hope that is ok.
The first one/this one clarifies that the excludePackages/Files only works for Scala2.
Will also send a PR on
sbt-scoverageto add a test for this.I need this functionality to work for Scala3, but would assume that it will be a while before dotty supports this out of the box.
Therefore I am thinking to add a
coverageExcludetask tosbt-scoveragethat will rewrite/cleanup thescoverage.coveragefile (remove the excluded packages, classes, files).This is can then be removed again as soon as dotty will support a comparable exclude capability.
Agreed?