-
Couldn't load subscription status.
- Fork 128
Re-enable PluginCoverageScalaJsTest, fix dangling UndefinedParam bug #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits Select commit Hold shift + click to select a range
585ed58 Try re-enabling PluginCoverageScalaJsTest
armanbilge 61be139 ScoverageCompiler refactoring to support SJS
armanbilge e5bbd14 Scala.js test is working again
armanbilge 8da1f01 Remove unneeded dep
armanbilge 66de565 Try adding buildInfo to root
armanbilge c13a068 Set crossScalaVersions for buildinfo project
armanbilge 0c69003 Revert "Remove unneeded dep"
armanbilge 7b9212b Add another sjs test dep
armanbilge d8d2a1c plugin also depends on runtimeJS for tests
armanbilge aa833a4 Actually enable the sjs compiler plugin :)
armanbilge 09f3673 Fix expected measured statements 4 -> 2
armanbilge 695ce2d Only catch non-fatals
armanbilge 775828f Make isScalaJsEnabled a lazy val
armanbilge 96136e5 I think these deps are unneeded now
armanbilge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ScoverageCompiler refactoring to support SJS
- Loading branch information
commit 61be139ab8cf31a065a1593da1c5cd851e17c1ab
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we have a separate build target for
buildInfoinstead of just including the buildInfo stuff inside of thepluginmodule and enabling theBuildInfoPluginthere?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, yes I suppose we could. I did this because the
BuildInfowas only needed in theTestscope and there's currently no way to configure that (see sbt/sbt-buildinfo#186). But I guess here if we "leak" theBuildInfoas part of the shipped plugin, it's probably not a big deal?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, that's sort of what I expected. No worries. Let's leave it as is.