Skip to content

Conversation

@nisshiee
Copy link
Contributor

@nisshiee nisshiee commented Jul 8, 2015

We should use HTTPS.

yui.yahooapis.com isn't accepting HTTPS request. So I changed link to cdnjs and checked both resources are same.

$ curl -s http://yui.yahooapis.com/pure/0.3.0/pure-min.css | md5sum; curl -s https://cdnjs.cloudflare.com/ajax/libs/pure/0.3.0/pure-min.css | md5sum ecb2a387c291b6f85ebada1054f33e09 - ecb2a387c291b6f85ebada1054f33e09 - 
@joprice
Copy link

joprice commented Feb 11, 2016

@nisshiee Looks like you have conflicts now. I'd like to see get merged.

@gslowikowski
Copy link
Member

Already changed in #143 and merged.

I've recently published scalac-scoverage-plugin version 1.2.0-SNAPSHOT and sbt-scoverage version 1.3.6-SNAPSHOT using it to Sonatype snapshots repo. You can try it.

@williamho
Copy link

I think the issue is that the https version of the pure-min.css file actually returns a 404: https://yui.yahooapis.com/pure/0.3.0/pure-min.css

(where this PR tries to change it to use cdnjs.cloudflare.com instead)

@gslowikowski
Copy link
Member

Ok, sorry, I've checked the commit and there are more changes. You must create new PR with this one change only.

@williamho williamho mentioned this pull request Feb 11, 2016
@williamho
Copy link

#151 has been merged, so I think this one can be closed now

@sksamuel
Copy link
Member

Thanks all

@sksamuel sksamuel closed this Feb 11, 2016
@joprice
Copy link

joprice commented Feb 11, 2016

sbt-coverage release following on this one?

@gslowikowski
Copy link
Member

I've published new 1.2.0-SNAPSHOT snapshot of scalac-scoverage-plugin. sbt-scoverage 1.3.6-SNAPSHOT should use update its dependency automatically.
I tried to test it, but found issue. You can run e.g. sbt clean coverage test, but cannot sbt clean test. I hope it will be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants