Ignored statements #117
Merged
Ignored statements #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Statements surrounded by $COVERAGE-OFF$ / $COVERAGE-ON$ tags are now included in the scoverage-data/scoverage.coverage.xml and scoverage.xml files however an "ignored" attribute has been added to the Statement object to indicate that the statement is contained within the above tags.
This count only includes statements excluded using the $COVERAGE-OFF$ tag, not those excluded using the sbt "coverageExcludedPackages" or maven "excludedPackages", etc. flags.
| Thanks for the PR. It looks good. There's a couple of test failures, if you can fix up I can merge. |
| Just noticed the failures, they are fixed now. |
| Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
An attempt to include ignored statements in the output. Not sure whether this is the best / correct way to approach this. Also can't see how to include statements that are in a whole class (or package) have been excluded, any suggestions?