Skip to content

Fixed that URL does not contain the "empty" #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2015
Merged

Fixed that URL does not contain the "empty" #103

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64e617c
Fixed that URL does not contain the "empty"
Feb 14, 2015
256a85b
Added tests for ScoverageHtmlWriter.scala
Feb 18, 2015
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed that URL does not contain the "empty" 
Order to remove the hierarchy of unnecessary 'empty' from a URL. Because the generated HTML links does not work correctly.
  • Loading branch information
magnolia committed Feb 14, 2015
commit 64e617c37f93effcfdcc5a610a587ac79128ce8f
4 changes: 1 addition & 3 deletions scalac-scoverage-plugin/src/main/scala/scoverage/report/ScoverageHtmlWriter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,7 @@ class ScoverageHtmlWriter(sourceDirectory: File, outputDir: File) {
val path = fileRelativeToSource.getParent
val value = fileRelativeToSource.getName

if (path.eq(null)) {
"(empty)/" + value
} else if (path.ne("")) {
if (path.ne("")) {
// (Normalise the pathSeparator to "/" in case we are running on Windows)
fileRelativeToSource.toString.replace(File.separator, "/")
} else {
Expand Down