FIX SLEP6 no errors raised when no metadata is passed #28256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
glemaitre reviewed Jan 25, 2024
| I am not sure that we want to fix it. Until we are experimental, I think that we don't want people to be able to have a mixture of supported and unsupported estimator. |
But if they don't pass any metadata, it doesn't really matter. |
That's true that we are not allowing for experimenting while you don't use the feature. So this is probably best to be lenient. |
glemaitre reviewed Jan 25, 2024
glemaitre reviewed Jan 25, 2024
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre approved these changes Feb 2, 2024
thomasjpfan added the To backport 
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Feb 10, 2024
…8256) Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
…8256) Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Feb 13, 2024
Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #28246
I'm not sure if this should be fixed though. But the fix is pretty trivial.
WDYT @OmarManzoor @glemaitre @thomasjpfan