[WIP] Modify Pipeline object to conform the current API of samplers #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chkoar changed the title chkoar changed the title 
Member
| Wouldn't it be better that our pipeline inherited from sklearn.pipeline.Pipeline and only overrode the fit/predict/predict_proba methods? This way, our pipeline would always be 'updated' and if sklearn ever support transform(axis=1) we could easily make the api compatible without the need of rewritting the Pipeline class. @glemaitre , thoughts? |
Member Author
| @dvro I think that you are right. |
Member
| Completely agree. |
Member
| However we will still have some issue with the testing. In fact we should execute the testing from sklearn to be sure that this is going through and our testing. |
Member
| Actually, every function in the Pipeline is overloaded so we will have anyway to take care about that class. |
Add testing for pipeline
christophe-rannou pushed a commit to christophe-rannou/imbalanced-learn that referenced this pull request Apr 3, 2017
[WIP] Modify Pipeline object to conform the current API of samplers
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
[WIP] Modify Pipeline object to conform the current API of samplers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Regarding to #38 and #75, this PR modifies the
sklearn.pipeline.Pipelineclass in order to adapt the current API of samplers. I have included one example using only samplers in the pipeline and one example using one transformer, two samplers and one classifier in the pipeline object. This PR needs test that I have not included.