[MRG] ROSE #754
Merged
[MRG] ROSE #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 30 commits August 21, 2020 11:34
Contributor Author
| Code should be ok. I have some issue with documentation build, though. Can anyone help me to give a direction, or tips about what's wrong? |
hayesall requested changes Sep 19, 2020
Member
hayesall left a comment
hayesall left a comment There was a problem hiding this comment.
Looking really good!
A few final changes (see comments), then I think this will be good to merge.
Member
| Can you also add a note to the "Enhancements" section for 0.7? https://github.com/scikit-learn-contrib/imbalanced-learn/blob/master/doc/whats_new/v0.7.rst |
Contributor Author
Sure. |
added 9 commits September 20, 2020 08:32
hayesall approved these changes Sep 20, 2020
Member
hayesall left a comment
hayesall left a comment There was a problem hiding this comment.
See comments for the last few fixes.
Otherwise, LGTM!
andrealorenzon added a commit to andrealorenzon/imbalanced-learn that referenced this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reference Issue
N/A
What does this implement/fix? Explain your changes.
Implementation of ROSE over-sampler method
Any other comments?
N/A