Skip to content

[MRG] FIX use a stump as base estimator in RUSBoostClassifier #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 11, 2019
Merged

[MRG] FIX use a stump as base estimator in RUSBoostClassifier #545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0685603
Use a stump as base estimator in RUSBoostClassifier
Feb 15, 2019
cd4e0bd
Call super _validate_estimator to set the default estimator
Feb 15, 2019
810e1e9
make pep8speaks happy
Feb 15, 2019
02c3f1d
Fix test
Feb 23, 2019
fa8008b
Merge remote-tracking branch 'origin/master' into rusboost_default_es…
glemaitre Jun 11, 2019
b960ec7
iter
glemaitre Jun 11, 2019
e7b4356
PEP8
glemaitre Jun 11, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
iter
  • Loading branch information
@glemaitre
glemaitre committed Jun 11, 2019
commit b960ec7c8621f4bdcf09dfcf71b66f5a051fe67a
5 changes: 3 additions & 2 deletions doc/ensemble.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,13 @@ Several methods taking advantage of boosting have been designed.
a boosting iteration [SKHN2010]_::

>>> from imblearn.ensemble import RUSBoostClassifier
>>> rusboost = RUSBoostClassifier(random_state=0)
>>> rusboost = RUSBoostClassifier(n_estimators=200, algorithm='SAMME.R',
... random_state=0)
>>> rusboost.fit(X_train, y_train) # doctest: +ELLIPSIS
RUSBoostClassifier(...)
>>> y_pred = rusboost.predict(X_test)
>>> balanced_accuracy_score(y_test, y_pred) # doctest: +ELLIPSIS
0.74...
0.66...

A specific method which uses ``AdaBoost`` as learners in the bagging classifier
is called EasyEnsemble. The :class:`EasyEnsembleClassifier` allows to bag
Expand Down
15 changes: 15 additions & 0 deletions doc/whats_new/v0.5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ Version 0.5 (under development)
Changelog
---------

Changed models
..............

The following models or function might give different results even if the
same data ``X`` and ``y`` are the same.

* :class:`imblearn.ensemble.RUSBoostClassifier` default estimator changed from
:class:`sklearn.tree.DecisionTreeClassifier` with full depth to a decision
stump (i.e., tree with ``max_depth=1``).

Documentation
.............

Expand Down Expand Up @@ -53,3 +63,8 @@ Bug
- Fix bug in :class:`imblearn.pipeline.Pipeline` where None could be the final
estimator.
:pr:`554` by :user:`Oliver Rausch <orausch>`.

- Fix bug by changing the default depth in
:class:`imblearn.ensemble.RUSBoostClassifier` to get a decision stump as a
weak learner as in the original paper.
:pr:`545` by :user:`Christos Aridas <chkoar>`.
2 changes: 1 addition & 1 deletion imblearn/ensemble/_weight_boosting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def fit(self, X, y, sample_weight=None):
def _validate_estimator(self):
"""Check the estimator and the n_estimator attribute, set the
`base_estimator_` attribute."""
super(RUSBoostClassifier, self)._validate_estimator()
super()._validate_estimator()

self.base_sampler_ = RandomUnderSampler(
sampling_strategy=self.sampling_strategy,
Expand Down