Skip to content

[MRG] Address issue #52 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glemaitre merged 1 commit into from
May 26, 2016
Merged

[MRG] Address issue #52 #53

glemaitre merged 1 commit into from
May 26, 2016

Conversation

@glemaitre
Copy link
Member

@glemaitre glemaitre commented May 26, 2016

  • Update the documentation of make_samples
  • Make the function in_danger_noise and make_samples private
Address issue scikit-learn-contrib#52
eff68c2 
- Update the documentation of `make_samples` - Make the function `in_danger_noise` and `make_samples` private
@glemaitre glemaitre changed the title Address issue #52 [MRG] Address issue #52 May 26, 2016
@glemaitre
Copy link
Member Author

glemaitre commented May 26, 2016

@fmfn Check if you wish some other changes?
@fmfn
Copy link
Collaborator

fmfn commented May 26, 2016

LGTM 👍
@glemaitre glemaitre merged commit d121c68 into scikit-learn-contrib:master May 26, 2016
@glemaitre glemaitre deleted the bug_make_samples branch June 26, 2016 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@glemaitre @fmfn