Edit Tomek Link definition #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sorry, it seems to me the definition is not completely correct.
Codecov Report
@@ Coverage Diff @@ ## master #506 +/- ## ======================================= Coverage 98.86% 98.86% ======================================= Files 82 82 Lines 5020 5020 ======================================= Hits 4963 4963 Misses 57 57Continue to review full report at Codecov.
|
glemaitre reviewed Nov 16, 2018
doc/under_sampling.rst Outdated
| .. math:: | ||
| d(x, y) < d(x, z) \text{ or } d(y, z) < d(x, y) | ||
| d(x, y) > d(x, z) \text{ or } d(x, y) > d(y, z) |
Member
There was a problem hiding this comment.
Actually I would edit the previous statement to make it more straight forward:
:class:`TomekLinks` detects the so-called Tomek's links [T2010]_. A Tomek's link between two samples of different class :math:`x` and :math:`y` is defined such that for any sample :math:`z`: .. math:: d(x, y) < d(x, z) \text{ or } d(x, y) < d(y, z) Contributor Author
There was a problem hiding this comment.
Yeah, probably more straitght forward, but should be AND then not OR.
Member
| Thanks to catch this up. Could you make an edit. |
Member
| Thanks for contributing. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Sorry, it seems to me the definition is not completely correct.