Skip to content

Conversation

@glemaitre
Copy link
Member

Reference Issue

closes #371

What does this implement/fix? Explain your changes.

Any other comments?

@glemaitre glemaitre mentioned this pull request Dec 1, 2017
4 tasks
@codecov
Copy link

codecov bot commented Dec 1, 2017

Codecov Report

Merging #379 into master will increase coverage by 0.01%.
The diff coverage is 92.94%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #379 +/- ## ========================================== + Coverage 98.74% 98.75% +0.01%  ========================================== Files 75 75 Lines 4543 4503 -40 ========================================== - Hits 4486 4447 -39  + Misses 57 56 -1
Impacted Files Coverage Δ
imblearn/combine/_smote_tomek.py 100% <ø> (ø) ⬆️
imblearn/metrics/_classification.py 96.72% <ø> (-0.06%) ⬇️
imblearn/ensemble/_balance_cascade.py 100% <ø> (ø) ⬆️
imblearn/pipeline.py 97.07% <ø> (ø) ⬆️
imblearn/combine/_smote_enn.py 100% <ø> (ø) ⬆️
imblearn/tests/test_common.py 95% <100%> (-0.46%) ⬇️
imblearn/utils/estimator_checks.py 96.44% <100%> (-0.02%) ⬇️
imblearn/ensemble/tests/test_bagging.py 100% <100%> (ø) ⬆️
imblearn/datasets/_zenodo.py 96.87% <50%> (-1.59%) ⬇️
imblearn/datasets/_imbalance.py 91.3% <50%> (-8.7%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe51ca3...b49707d. Read the comment docs.

@massich
Copy link
Contributor

massich commented Dec 1, 2017

This crashes all over the place, 'cos the CI's still install scikit-learn 0.19, should not we wait until release? Or at least pip install from master?

@glemaitre
Copy link
Member Author

glemaitre commented Dec 1, 2017 via email

@glemaitre glemaitre force-pushed the master branch 5 times, most recently from bf1ec62 to 23ad602 Compare February 28, 2018 22:36
@pep8speaks
Copy link

pep8speaks commented Sep 3, 2018

Hello @glemaitre! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on September 04, 2018 at 15:01 Hours UTC
@glemaitre glemaitre merged commit c0a4208 into scikit-learn-contrib:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants