Skip to content

Conversation

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Aug 10, 2017

Reference Issue

closes #252
closes #149

What does this implement/fix? Explain your changes.

Implement EasyEnsemble as a meta-estimator. We call it BalancedBaggingClassifier since it is what it does.

Any other comments?

@codecov
Copy link

codecov bot commented Aug 11, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@2e7c070). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #315 +/- ## ======================================== Coverage ? 98.1% ======================================== Files ? 68 Lines ? 4071 Branches ? 0 ======================================== Hits ? 3994 Misses ? 77 Partials ? 0
Impacted Files Coverage Δ
imblearn/ensemble/balance_cascade.py 100% <ø> (ø)
imblearn/ensemble/easy_ensemble.py 100% <ø> (ø)
imblearn/ensemble/__init__.py 100% <100%> (ø)
imblearn/ensemble/tests/test_easy_ensemble.py 100% <100%> (ø)
imblearn/ensemble/tests/test_classifier.py 100% <100%> (ø)
imblearn/ensemble/classifier.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7c070...341cf95. Read the comment docs.

@glemaitre glemaitre force-pushed the master branch 2 times, most recently from 1b22868 to 33660d4 Compare August 11, 2017 14:43
@glemaitre glemaitre changed the title [WIP] EHN add BalancedBaggingClassifier [MRG] EHN add BalancedBaggingClassifier Aug 12, 2017
@glemaitre
Copy link
Member Author

@massich @chkoar review time ;)
The test are the same than in scikit-learn with sample_weight which is not supported.

@glemaitre
Copy link
Member Author

@chkoar I would be inclined to move the meta-estimator. I am not sure where indeed.
If we think about it, all predictors would probably some ensemble which use a specific sampling (SMOTEBoost, etc.) It might make sense to have a subpackage predictor with inside different module ensemble.py, smote.py ...

@glemaitre glemaitre mentioned this pull request Aug 14, 2017
3 tasks
@massich
Copy link
Contributor

massich commented Aug 22, 2017

despite the rebase and the nosetest asserts LGTM

@glemaitre glemaitre merged commit a4947ea into scikit-learn-contrib:master Aug 24, 2017
@amueller
Copy link
Member

sweet :)

@glemaitre
Copy link
Member Author

We have for EuroScipy next week ;) We got in release mode chasing scikit-learn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants